Merge pull request #82 from geneontology/issue-81-missing-reference-url

Render evidence icon in a span when URL not available
geneontology · Mar 3, 2025 · bbcdbca · bbcdbca
2 parents 8d0bd05 + 08808f8
commit bbcdbca
Showing 1 changed file with 21 additions and 5 deletions.
diff --git a/src/components/genes-panel/genes-panel.tsx b/src/components/genes-panel/genes-panel.tsx
@@ -124,13 +124,29 @@ export class GenesPanel {
             <span>
                 {
                     evidences.map(evidence => {
-                        if (!evidence.reference || !evidence.referenceEntity) {
+                        if (!evidence.reference) {
                             return null; // for extreme case
                         }
-                        return <a href={evidence.referenceEntity.url} target='_blank'
-                            title={"Source: " + evidence.reference + "\nEvidence: " + evidence.evidence.label}>
-                            {this.renderReferenceIcon()}
-                        </a>
+                        const elementTitle = "Source: " + evidence.reference + "\nEvidence: " + evidence.evidence.label;
+                        if (evidence.referenceEntity?.url) {
+                            return (
+                                <a
+                                    href={evidence.referenceEntity.url}
+                                    target='_blank'
+                                    title={elementTitle}
+                                >
+                                    {this.renderReferenceIcon()}
+                              </a>
+                            )
+                        } else {
+                            return (
+                                <span
+                                    title={elementTitle}
+                                >
+                                    {this.renderReferenceIcon()}
+                                </span>
+                            )
+                        }
                     })
                 }
             </span>