PB-1126: Removed the update_interval field from item and collections model #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltshb
force-pushed
the
feat-PB-1126-update-interval
branch
3 times, most recently
from
caacb28 to
cb15243
Compare
ltshb
changed the title
boecklic
approved these changes
Mar 4, 2025
app/stac_api/views/mixins.py
Outdated
Comment on lines
201
to
203
| parts = [i.strip() for i in cache_control_header.split(',')] | ||
| args = {i.split('=')[0].strip(): i.split('=')[-1].strip() for i in parts if i} | ||
| return {k: True if v == k else v for k, v in args.items()} |
There was a problem hiding this comment.
seeing this here I definitely think we should have some validation for that field, see comment here: #528 (comment)
ltshb
force-pushed
the
feat-PB-1126-update-interval
branch
2 times, most recently
from
fc1942c to
48e3b44
Compare
ltshb
force-pushed
the
feat-PB-1126-cache-header-field
branch
3 times, most recently
from
0a05bd8 to
ace467f
Compare
…model Now use the previously new cache_control_header field on the collection model to overwrite the default cache settings of assets, items and collections endpoints. Note that endpoints that aggregate several collections like the search endpoint and the collections list endpoint have now caching disabled to avoid any caching issues and to keep the code simple.
ltshb
force-pushed
the
feat-PB-1126-update-interval
branch
from
48e3b44 to
6914de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to performance issue we removed the
update_intervalfield on the item and collection level and replace it by a single filedcache_control_headeron the collection level.Now use the previously new cache_control_header field on the collection model
to overwrite the default cache settings of assets, items and collections
endpoints. Note that endpoints that aggregate several collections like the
search endpoint and the collections list endpoint have now caching disabled
to avoid any caching issues and to keep the code simple.