Move layer visibility toggle to the left of the layer title and icon #487
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Integration tests report: appsharing.space |
|
Boo to that linting rule 😆 whitespace can be an incredibly valuable tool for readability. Anyone feel strongly about changing it? |
|
please update snapshots |
|
The snapshots didn't update, don't know why - I'd just ask the bot to please update snapshots again |
|
Oh it fails again - https://github.com/geojupyter/jupytergis/actions/runs/13523809762/job/37789149195?pr=487#step:11:3347 I haven't looked in too deep yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #244
Before:
After:
Keeping the button on the right raises questions about how to handle when the button overlaps with the text. After playing with it for a bit, I felt that having the button on the left is ideal. Especially as we move towards implementing #486, I feel having the button on the right misses an opportunity to convey information about grouping through indentation of the button. With the button on the right, the eye has to do more scanning from left-to-right.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--487.org.readthedocs.build/en/487/
💡 JupyterLite preview: https://jupytergis--487.org.readthedocs.build/en/487/lite