-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release.yml #187
Update release.yml #187
Conversation
gwbres
commented
Nov 29, 2023
•
edited
Loading
edited
- remove cargo.release profile, it's better to customize this in the CI script rather than stripping any released binaries to ever be produced in the workspace
- add x86_64-unknown-linux-gnu which seems to the standard linux target
- add macos-x86: trying to see if the current macos triggers the same link error
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
I'm probably missing something, is |
Nightly is not required to build this crate, the only requirement is rustc > 0.64 or 0.70 I can't remember exactly, I copied and adapted this script from other crates, and they used nightly on non Linux distros, from what I just explaned, would you say we could use a stable rust everywhere then ? |
Yes, definitely stable. |
Signed-off-by: Guillaume W. Bres <[email protected]>
awesome, all targets build correctly (including both macos) except musl-gcc. I don't understand why it's failling to grab the compiled binaries though, I just proved they exist with an |
|