Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release.yml #187

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Update release.yml #187

merged 4 commits into from
Nov 29, 2023

Conversation

gwbres
Copy link
Collaborator

@gwbres gwbres commented Nov 29, 2023

  • remove cargo.release profile, it's better to customize this in the CI script rather than stripping any released binaries to ever be produced in the workspace
  • add x86_64-unknown-linux-gnu which seems to the standard linux target
  • add macos-x86: trying to see if the current macos triggers the same link error

@gwbres gwbres self-assigned this Nov 29, 2023
Signed-off-by: Guillaume W. Bres <[email protected]>
@lnicola
Copy link
Member

lnicola commented Nov 29, 2023

I'm probably missing something, is nightly required?

@gwbres
Copy link
Collaborator Author

gwbres commented Nov 29, 2023

I'm probably missing something, is nightly required?

Nightly is not required to build this crate, the only requirement is rustc > 0.64 or 0.70 I can't remember exactly,
which is already provided on Debian for instance.

I copied and adapted this script from other crates, and they used nightly on non Linux distros, from what I just explaned, would you say we could use a stable rust everywhere then ?

@lnicola
Copy link
Member

lnicola commented Nov 29, 2023

Yes, definitely stable.

Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres gwbres merged commit 2be6e55 into main Nov 29, 2023
4 checks passed
@gwbres
Copy link
Collaborator Author

gwbres commented Nov 30, 2023

@larsnaesbye;

awesome, all targets build correctly (including both macos) except musl-gcc.
I presume my last simplification has caused musl-gcc to fail.
I'll suggest I'll remove musl-gcc from what you told us @lnicola, this is not standard.

I don't understand why it's failling to grab the compiled binaries though, I just proved they exist with an ls -l and that works fine in my other crates

@lnicola
Copy link
Member

lnicola commented Nov 30, 2023

musl-gcc comes from musl-tools, you need to install that using apt. I don't understand why the other targets are failing though.

@gwbres gwbres deleted the ci-release branch November 30, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants