Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CGGTTS, reset the tracker after it is released. #289

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

vicalloy
Copy link
Contributor

@vicalloy vicalloy commented Jan 6, 2025

If tracker.fit fails, tracker.reset() will not be called, and the samples will be kept for the next period.
This commit resets the tracker after tacker release.

@gwbres
Copy link
Collaborator

gwbres commented Jan 6, 2025

my big question in CGGTTS track fitting process, is whether we should tolerate data gaps or not.
I presume we should, because it is unrealistic to hope for 15' steady observations.
And after all, that is the whole point of a fitting algorithm

@gwbres gwbres merged commit 8ddccae into georust:main Jan 6, 2025
25 of 26 checks passed
@vicalloy
Copy link
Contributor Author

vicalloy commented Jan 7, 2025

my big question in CGGTTS track fitting process, is whether we should tolerate data gaps or not. I presume we should, because it is unrealistic to hope for 15' steady observations. And after all, that is the whole point of a fitting algorithm

Yes, I have the same question. In my scenario, my sample interval is 1 second, and missing one sample is not a significant issue for the result.
Maybe we can add a ratio parameter for the minimum sample count.

@gwbres
Copy link
Collaborator

gwbres commented Jan 7, 2025

The tracker should simply have a gap Duration tolerance, which seems the best parameter to tune by the user (depending on requirements and application). I would also argue that the tracker's default behavior should be very tolerant (tolerate almost "any" gap) for very basic applications. To me that would be 3 points per CvPeriod. Which is incompatible with high quality CGGTTS, but just works. In your 1Hz (""fast"" observation application), you could for example specify a 30s tolerance, which would be compatible with high quality CGGTTTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants