Cancel running requests when discarding or publishing content #7037
+53
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure that discard and publish requests cancel ongoing or schedule save requests properly, to avoid race conditions.
Summary of changes
panel.content.cancelSaving()
methodpanel.content.discard()
andpanel.content.publish()
cancel any ongoing or scheduled save requests. They also no longer can be executed for other views than the current one.panel.content.save()
no longer sets theisProcessing
flag. Otherwise, discard and publish will be blocked.Ready?
For review team