-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend e2e tests #3127
Add backend e2e tests #3127
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1f3652d | 361.62 ms | 424.76 ms | 63.14 ms |
86f0096 | 381.33 ms | 476.58 ms | 95.25 ms |
c7e2fbc | 393.98 ms | 478.24 ms | 84.27 ms |
e6ffd7b | 379.52 ms | 449.30 ms | 69.78 ms |
0bd723b | 412.52 ms | 496.65 ms | 84.13 ms |
3d8bd2b | 375.34 ms | 446.32 ms | 70.98 ms |
4e260b3 | 384.08 ms | 477.56 ms | 93.48 ms |
9119d59 | 407.12 ms | 509.64 ms | 102.52 ms |
4e29063 | 376.38 ms | 390.98 ms | 14.60 ms |
0bd723b | 375.20 ms | 452.41 ms | 77.20 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1f3652d | 1.72 MiB | 2.27 MiB | 554.95 KiB |
86f0096 | 1.72 MiB | 2.29 MiB | 576.50 KiB |
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
e6ffd7b | 1.72 MiB | 2.29 MiB | 579.13 KiB |
0bd723b | 1.72 MiB | 2.29 MiB | 578.09 KiB |
3d8bd2b | 1.72 MiB | 2.29 MiB | 577.53 KiB |
4e260b3 | 1.72 MiB | 2.27 MiB | 554.95 KiB |
9119d59 | 1.70 MiB | 2.27 MiB | 583.84 KiB |
4e29063 | 1.72 MiB | 2.29 MiB | 578.38 KiB |
0bd723b | 1.72 MiB | 2.29 MiB | 578.09 KiB |
Previous results on branch: feat/backend-e2e-tests
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
eaea817 | 390.43 ms | 461.30 ms | 70.87 ms |
b87fb2b | 448.86 ms | 531.02 ms | 82.16 ms |
6fb3a13 | 398.49 ms | 436.70 ms | 38.21 ms |
06c4443 | 407.92 ms | 485.69 ms | 77.77 ms |
1959d29 | 408.73 ms | 486.68 ms | 77.95 ms |
fba097d | 440.16 ms | 511.28 ms | 71.12 ms |
df6f13d | 456.69 ms | 538.70 ms | 82.01 ms |
922dd4a | 442.44 ms | 496.39 ms | 53.95 ms |
02d7b93 | 395.77 ms | 474.56 ms | 78.79 ms |
5a3dcb4 | 376.96 ms | 443.90 ms | 66.94 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
eaea817 | 1.70 MiB | 2.27 MiB | 583.84 KiB |
b87fb2b | 1.72 MiB | 2.27 MiB | 558.56 KiB |
6fb3a13 | 1.72 MiB | 2.27 MiB | 558.56 KiB |
06c4443 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
1959d29 | 1.72 MiB | 2.27 MiB | 558.56 KiB |
fba097d | 1.72 MiB | 2.27 MiB | 558.56 KiB |
df6f13d | 1.72 MiB | 2.27 MiB | 558.56 KiB |
922dd4a | 1.72 MiB | 2.27 MiB | 558.56 KiB |
02d7b93 | 1.70 MiB | 2.27 MiB | 583.82 KiB |
5a3dcb4 | 1.72 MiB | 2.27 MiB | 558.30 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor things and I didn't check the test code, only configs and gradle files, but LGTM otherwise 🚢
Actuator has only been added to one of the sample projects and should be there for all so the ...wait for spring ... script doesn't wait the full duration but stops when the server is ready. |
JUNIT test reports seem to override each other |
.../sentry-samples-spring-boot-jakarta/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt
Outdated
Show resolved
Hide resolved
.../sentry-samples-spring-boot-jakarta/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt
Outdated
Show resolved
Hide resolved
.../sentry-samples-spring-boot-jakarta/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt
Outdated
Show resolved
Hide resolved
...es/sentry-samples-spring-boot-jakarta/src/test/kotlin/io/sentry/systemtest/TodoSystemTest.kt
Outdated
Show resolved
Hide resolved
...es/sentry-samples-spring-boot-jakarta/src/test/kotlin/io/sentry/systemtest/TodoSystemTest.kt
Outdated
Show resolved
Hide resolved
...samples-spring-boot-jakarta/src/test/kotlin/io/sentry/systemtest/grahql/GraphqlTestClient.kt
Outdated
Show resolved
Hide resolved
...spring-boot-webflux-jakarta/src/test/kotlin/io/sentry/systemtest/grahql/GraphqlTestClient.kt
Outdated
Show resolved
Hide resolved
...samples-spring-boot-webflux/src/test/kotlin/io/sentry/systemtest/grahql/GraphqlTestClient.kt
Outdated
Show resolved
Hide resolved
.../sentry-samples-spring-boot/src/test/kotlin/io/sentry/systemtest/grahql/GraphqlTestClient.kt
Outdated
Show resolved
Hide resolved
.../sentry-samples-spring-boot/src/test/kotlin/io/sentry/systemtest/grahql/GraphqlTestClient.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
#skip-changelog
📜 Description
Add some end to end tests for backend.
💡 Motivation and Context
To catch breaking changes early.
💚 How did you test it?
;-)
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps