Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle=8.6, AGP=8.3.0, kotlin=1.9.22, compose=1.5+ #3263

Closed
wants to merge 32 commits into from

Conversation

markushi
Copy link
Member

@markushi markushi commented Mar 11, 2024

📜 Description

An attempt to see what works / is broken, as well if this may resolves our stuck github runners.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f6745e7

@markushi markushi changed the title Bump Gradle=8.6, AGP=8.2.0, kotlin=1.9.22, compose=1.5.12 Bump Gradle=8.6, AGP=8.3.0, kotlin=1.9.22, compose=1.5+ Mar 15, 2024
Copy link
Contributor

github-actions bot commented Mar 18, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 462.43 ms 569.28 ms 106.85 ms
Size 2.27 MiB 2.68 MiB 421.53 KiB

@markushi markushi marked this pull request as ready for review March 18, 2024 09:38
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we also should check what maven publications look like now, I think there were some changes with regards to that (maybe we have to update maven-publish-plugin).

And also check sentry-compose publication specifically as there's probably also some changes in kmp gradle plugin

@markushi
Copy link
Member Author

Closing in favor of individual PRs to bump Gradle, AGP, ...

@markushi markushi closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants