Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MetricResourceIdentifier #3282

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Mar 25, 2024

#skip-changelog

📜 Description

Follow up for #3273

💡 Motivation and Context

Broken JavaDoc

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer requested a review from markushi March 25, 2024 12:50
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ddbc0e2

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 422.86 ms 494.72 ms 71.86 ms
Size 1.70 MiB 2.28 MiB 592.01 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
95a98b5 380.06 ms 453.56 ms 73.50 ms
c554ca2 368.52 ms 430.74 ms 62.22 ms
1f3652d 361.62 ms 424.76 ms 63.14 ms
baaf637 418.39 ms 496.86 ms 78.47 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms
0404ea3 394.73 ms 461.79 ms 67.06 ms
0bf143e 368.35 ms 437.47 ms 69.12 ms
baaf637 375.71 ms 441.58 ms 65.87 ms
a537f8a 384.76 ms 456.59 ms 71.83 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms

App size

Revision Plain With Sentry Diff
95a98b5 1.70 MiB 2.27 MiB 586.31 KiB
c554ca2 1.70 MiB 2.27 MiB 582.25 KiB
1f3652d 1.72 MiB 2.27 MiB 554.95 KiB
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
0bf143e 1.72 MiB 2.29 MiB 576.50 KiB
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
a537f8a 1.70 MiB 2.27 MiB 584.74 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB

@adinauer adinauer merged commit fde534e into main Mar 25, 2024
25 of 26 checks passed
@adinauer adinauer deleted the feat/remove-metric-resource-identifier branch March 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants