Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check tracePropagationTargets in OpenTelemetry propagator #4191

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

adinauer
Copy link
Member

📜 Description

If we can extract the URL from span attributes, we check it against tracePropagationTargets to see if we should attach the tracing headers. If no URL can be extracted, we always attach the headers.

💡 Motivation and Context

Fixes #4173

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer marked this pull request as draft February 21, 2025 08:56
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 376.17 ms 424.57 ms 48.40 ms
Size 1.58 MiB 2.21 MiB 641.62 KiB

@adinauer adinauer marked this pull request as ready for review February 24, 2025 05:23
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer merged commit c8461d4 into main Feb 25, 2025
35 checks passed
@adinauer adinauer deleted the fix/otel-trace-propagation-targets branch February 25, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check URL when attaching tracing headers in OpenTelemetry propagator
2 participants