Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignoredErrors, ignoredTransactions and ignoredCheckIns being unset by external options #4207

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix ignoredErrors, ignoredTransactions and ignoredCheckIns being unset by external options #4207

merged 2 commits into from
Feb 25, 2025

Conversation

adinauer
Copy link
Member

📜 Description

Fix ignoredErrors, ignoredTransactions and ignoredCheckIns being unset by external options if not present in any external config mechanism.

💡 Motivation and Context

Fixes #4205

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 643.43 ms 767.64 ms 124.21 ms
Size 1.58 MiB 2.21 MiB 641.62 KiB

Previous results on branch: fix/external-options-unset-filters

Startup times

Revision Plain With Sentry Diff
7ea9ceb 418.40 ms 440.92 ms 22.52 ms

App size

Revision Plain With Sentry Diff
7ea9ceb 1.58 MiB 2.21 MiB 641.61 KiB

lcian
lcian approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer merged commit afe9d2c into main Feb 25, 2025
35 checks passed
@adinauer adinauer deleted the fix/external-options-unset-filters branch February 25, 2025 11:28
@dalbani dalbani mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merging of undefined external option of type "list" overrides internal one actually defined
2 participants
@adinauer @lcian