Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse util classes for System tests #4236

Open
wants to merge 2 commits into
base: feat/distributed-tracing-system-tests
Choose a base branch
from

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Mar 6, 2025

#skip-changelog

📜 Description

Classes that were duplicated across all system test modules are now located in the sentry-system-test-support module.

💡 Motivation and Context

Allows us to have less duplication, making it easier to add new tests.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8a31db1

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.91 ms 404.49 ms 2.58 ms
Size 1.58 MiB 2.21 MiB 641.83 KiB

Baseline results on branch: feat/distributed-tracing-system-tests

Startup times

Revision Plain With Sentry Diff
a75dbee 369.13 ms 428.11 ms 58.98 ms

App size

Revision Plain With Sentry Diff
a75dbee 1.58 MiB 2.21 MiB 641.82 KiB

Previous results on branch: feat/reuse-test-support-for-system-tests

Startup times

Revision Plain With Sentry Diff
3b5ce95 381.59 ms 427.42 ms 45.83 ms

App size

Revision Plain With Sentry Diff
3b5ce95 1.58 MiB 2.21 MiB 641.82 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants