ref(eap-mutations): Implement synchronizer #6436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Induce a hardcoded delay so that the eap-mutations consumer will always lag behind the eap-spans consumer. This PR (and most of my work on the mutations consumer) makes a point to not use custom strategies, as that's too much boilerplate. Rather, we should improve the arroyo API. For this PR, this arroyo PR is necessary: getsentry/arroyo#388
untitaker
changed the title
evanh
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Question: presumably this is going to cause a bunch of errors to get thrown, at least when it is first deployed, since none of the messages coming in currently have been delayed.
Is there a concern with that at all? Or is it just something that will blip for a bit and then stabilize?
|
those errors are not logged, just causing backpressure (paused state in arroyo) arroyo will emit a warning at most every 5 seconds for when the consumer is seeing an abnormal/constant amount of backpressure, so that might cause some noise in sentry. but we already have an issue for that, so it should group nicely. |
ayirr7
reviewed
Oct 17, 2024
ayirr7
reviewed
Oct 17, 2024
| @@ -97,6 +101,12 @@ impl ProcessingStrategyFactory<KafkaPayload> for MutConsumerStrategyFactory { | |||
| Some("parse"), | |||
| ); | |||
|
|
|||
| let mut synchronizer = Synchronizer { | |||
| min_delay: TimeDelta::days(1), | |||
There was a problem hiding this comment.
Any reason why we specifically chose 1 day here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Induce a hardcoded delay so that the eap-mutations consumer will always
lag behind the eap-spans consumer.
This PR (and most of my work on the mutations consumer) makes a point to not use custom strategies, as that's too much
boilerplate. Rather, we should improve the arroyo API. For this PR, this
arroyo PR is necessary: getsentry/arroyo#388