Changeable ticks timing and fix an include path issue #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gymadarasz
changed the title
gymadarasz
added a commit
to gymadarasz/PHPWebsockets
that referenced
this pull request
Apr 10, 2018
issue 1: PHP can't find the users.php if includes are in a different folder and it caused a php fatal error (more flexible solution is an autoloader for e.g. composer) issue 2: tick() function called once per seconds but these protected variables able to the extender class to override the tick speed even dynamically See in original PR: ghedipunk#98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I really like your useful project however I found two issue when I tried to install at first time. I think not me the first who having same issues so I fix it:
issue 1: PHP can't find the users.php if includes are in a different folder and it caused a php fatal error (more flexible solution is an autoloader for e.g. composer)
issue 2: tick() function called once per seconds but these protected variables able to the extender class to override the tick speed even dynamically