New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(navi): add SafeAreaView correctly #884

Merged

chinesedfan merged 4 commits into gitpoint:master from chinesedfan:fix-navi

Jul 4, 2019

Member

chinesedfan commented Jul 4, 2019 •

edited

Loading

For issues #854, #870, #873.

react-navigation integrated SafeAreaView in its header and tab bar. But we set header: null for several screens, which means SafeAreaView should be added in them by ourselves.
Upgraded react-native-safe-area-view to handle iPhone XMax.
Upgraded react-native-device-info to handle new phones, especially for Android. Ref here.

chinesedfan added 4 commits

July 2, 2019 00:02


          fix: upgrade dep and wrap with SafeAreaView

e88f265


          fix: fix margin top

85d287f


          fix: add SafeAreaView in screen to fix top color

1e23e9b


          feat: prepare for Android notch

5f52e6d

coveralls commented Jul 4, 2019

Coverage decreased (-0.02%) to 48.648% when pulling 5f52e6d on chinesedfan:fix-navi into b8051b2 on gitpoint:master.

chinesedfan merged commit df9cb65 into gitpoint:master

chinesedfan mentioned this pull request

fix: provide real safe area view #911

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet