-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable opening datasets with gcps even if no valid crs is present #182
Draft
weiji14
wants to merge
8
commits into
gjoseph92:main
Choose a base branch
from
weiji14:open_vrt_with_gcps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
66f3781
Enable opening datasets with gcps even if no valid crs is present
weiji14 4f656fe
Get src_crs from last index position of gcps tuple
weiji14 edbf3a9
Add a unit test to check that reading GeoTIFFs with gcps work
weiji14 cc0cd1f
Add an inline comment about trying to make VRT when gcps are present
weiji14 1b3c47c
Remove duplicated WarpedVRT instantiation
weiji14 1fb37c7
avoid mutating `spec.vrt_params`
gjoseph92 fca7961
fix up test imports
gjoseph92 d7b0820
fix conditional
gjoseph92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import tempfile | ||
|
||
import numpy as np | ||
from rasterio.control import GroundControlPoint | ||
from rasterio.crs import CRS | ||
from rasterio.enums import Resampling | ||
from rasterio.windows import Window | ||
from stackstac.raster_spec import RasterSpec | ||
from stackstac.rio_reader import AutoParallelRioReader | ||
|
||
|
||
def test_dataset_read_with_gcps(): | ||
""" | ||
Ensure that GeoTIFFs with ground control points (gcps) can be read using | ||
AutoParallelRioReader. | ||
|
||
Regression test for https://github.com/gjoseph92/stackstac/issues/181. | ||
""" | ||
with tempfile.NamedTemporaryFile(suffix=".tif") as tmpfile: | ||
src_gcps = [ | ||
GroundControlPoint(row=0, col=0, x=156113, y=2818720, z=0), | ||
GroundControlPoint(row=0, col=800, x=338353, y=2785790, z=0), | ||
GroundControlPoint(row=800, col=800, x=297939, y=2618518, z=0), | ||
GroundControlPoint(row=800, col=0, x=115698, y=2651448, z=0), | ||
] | ||
crs = CRS.from_epsg(32618) | ||
with rasterio.open( | ||
tmpfile.name, | ||
mode="w", | ||
height=800, | ||
width=800, | ||
count=1, | ||
dtype=np.uint8, | ||
driver="GTiff", | ||
) as source: | ||
source.gcps = (src_gcps, crs) | ||
|
||
reader = AutoParallelRioReader( | ||
url=tmpfile.name, | ||
spec=RasterSpec( | ||
epsg=4326, bounds=(90, -10, 110, 10), resolutions_xy=(10, 10) | ||
), | ||
resampling=rasterio.enums.Resampling.bilinear, | ||
dtype=np.float32, | ||
fill_value=np.nan, | ||
rescale=True, | ||
) | ||
array = reader.read(window=Window(col_off=0, row_off=0, width=10, height=10)) | ||
|
||
np.testing.assert_allclose( | ||
actual=array, desired=np.array([[0.0, 0.0], [0.0, 0.0]], dtype=np.float32) | ||
) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't thank me yet, this is a really bad test 😅 It only checks that things can run (and that a GeoTIFF with gcps works without an error message), but I don't like this assert statement... Any pointers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, maybe we could read it back using rasterio with (what we think are) the right parameters, and check that the results match?
Only other thing I can think of would be to write some data into the file (probably like
np.linspace(...).reshape(...)
). Then we could make a more meaningful assertion about the values we get out.