Add "generate function" code action #4168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocavalieri
force-pushed
the
generate-function
branch
from
80d099f to
9f31f9c
Compare
giacomocavalieri
force-pushed
the
generate-function
branch
from
9f31f9c to
2c93074
Compare
lpil
reviewed
Jan 11, 2025
| .named_type_name() | ||
| .map(|(_type_module, type_name)| type_name.to_snake_case()) | ||
| .filter(|name| is_valid_function_name(name)) | ||
| .unwrap_or(String::from("arg")); |
There was a problem hiding this comment.
Let's use a real word rather than arg. We don't abbreviate in Gleam.
There was a problem hiding this comment.
Would you prefer "value" or "argument" or something else entirely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "generate function" code action. Here's an example showcasing it in various scenarios (function calls, pipelines, functions inside pipelines):
This PR is a WIP since it's based on #4167 and won't work properly until that's merged