Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions view: move loading of task attributes etc... into own func #31494

Merged
merged 8 commits into from
Feb 2, 2025
Merged

actions view: move loading of task attributes etc... into own func #31494

merged 8 commits into from
Feb 2, 2025

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 25, 2024

just a smal refactor to make the function length smaler ... and code more reusable in the future

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 25, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 25, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2024
@6543 6543 requested a review from techknowlogick June 25, 2024 22:30
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 25, 2024
@6543
Copy link
Member Author

6543 commented Jun 25, 2024

review it via: https://github.com/go-gitea/gitea/pull/31494/files?diff=unified&w=1 make it simple :D

@6543 6543 requested a review from KN4CK3R June 30, 2024 00:47
@lunny
Copy link
Member

lunny commented Jul 23, 2024

Tests are necessary.

@6543
Copy link
Member Author

6543 commented Jul 23, 2024 •
edited
Loading

Tests are necessary.

yes and the code is not in the right place ... as there is code logic I would expect more in the services package etc ...

this is just a small refactor, do i need tests when they initially where not here... yes they should be added

if that's a blocker, #24980 and #24516 also should never have been merged as they actually touch this code and change it's behavior.

@wxiaoguang
Copy link
Contributor

I have split the LogCursor in #32713 , and there is a mock endpint (see the /devtest list)

I think they could make the development easier. Would you still like to make following up changes in this PR?

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Dec 29, 2024
@wxiaoguang
Copy link
Contributor

@6543 ping

@6543
Copy link
Member Author

6543 commented Jan 20, 2025 •
edited
Loading

convlicts resolved

@6543
Copy link
Member Author

6543 commented Jan 20, 2025

I think they could make the development easier. Would you still like to make following up changes in this PR?

well I wont add frontend tests for actions just for get this smal code split merged ... but If someone else wana do It' I'll happily accept such pulls/patches

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 21, 2025
@wxiaoguang wxiaoguang removed the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Jan 21, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 21, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 1, 2025 •
edited
Loading

@lunny @techknowlogick @KN4CK3R

Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/31494/files?diff=unified&w=1

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 1, 2025
@lunny lunny enabled auto-merge (squash) February 1, 2025 02:44
@lunny lunny merged commit fcfe1fb into go-gitea:main Feb 2, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 2, 2025
@techknowlogick techknowlogick deleted the refactor_just-splitit branch February 2, 2025 04:03
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 3, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6462e8f 
* giteaofficial/main: (53 commits)
  [skip ci] Updated licenses and gitignores
  Correct bot label `vertical-align` (go-gitea#33477)
  chore: fix some trivial problems and TODOs (go-gitea#33473)
  Worktime tracking for the organization level (go-gitea#19808)
  Skip deletion error for action artifacts (go-gitea#33476)
  Update .changelog file to add performance label group (go-gitea#33472)
  actions view: move loading of task attributes etc... into own func (go-gitea#31494)
  [skip ci] Updated translations via Crowdin
  Update feishu icon (go-gitea#33470)
  Inclusion of rename organization api (go-gitea#33303)
  [skip ci] Updated translations via Crowdin
  Hide/disable unusable UI elements when a repository is archived (go-gitea#33459)
  Fix SSH LFS memory usage (go-gitea#33455)
  Revert empty lfs ref name (go-gitea#33454)
  Update `@github/text-expander-element`, adapt type imports (go-gitea#33449)
  Support choose email when creating a commit via web UI (more) (go-gitea#33445)
  Fix issue sidebar dropdown keyboard support (go-gitea#33447)
  Fix "redirect link" handling (go-gitea#33440)
  Refactor repository transfer (go-gitea#33211)
  Enable two more strict options in tsconfig (go-gitea#33438)
  ...
@6543 6543 mentioned this pull request Feb 4, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @wxiaoguang @KN4CK3R @GiteaBot