Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support workflow event dispatch via API #32059

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feature: Support workflow event dispatch via API #32059

wants to merge 9 commits into from

Conversation

bencurio
Copy link

@bencurio bencurio commented Sep 17, 2024 •
edited
Loading

ref: #31765

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 17, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 17, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Sep 17, 2024
@bencurio bencurio force-pushed the main branch 2 times, most recently from 727cd1f to 8814e9f Compare September 17, 2024 16:00
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 20, 2024
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 2, 2024
@bencurio bencurio marked this pull request as ready for review October 2, 2024 10:18
@bencurio bencurio changed the title [WIP] Feature: Support workflow event dispatch via API Feature: Support workflow event dispatch via API Oct 2, 2024
lunny
lunny reviewed Oct 3, 2024
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Oct 11, 2024
View reviewed changes
services/actions/workflow.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2024
@lunny lunny added this to the 1.23.0 milestone Oct 21, 2024
lunny
lunny reviewed Oct 21, 2024
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Oct 21, 2024
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
@lunny lunny modified the milestones: 1.23.0, 1.24.0 Nov 6, 2024
@KodingDev
Copy link

Any updates on this?

@bencurio
Copy link
Author

bencurio commented Dec 4, 2024

I'm sorry, but due to my current workload, I don't have the capacity to handle the PR at the moment. However, if the code review is completed in full, I can address all the corrections at once. Thank you.

@lunny
Copy link
Member

lunny commented Dec 4, 2024

I'm sorry, but due to my current workload, I don't have the capacity to handle the PR at the moment. However, if the code review is completed in full, I can address all the corrections at once. Thank you.

would you mind maintainers send commits to your branch？

@bencurio
Copy link
Author

bencurio commented Dec 4, 2024

I'm sorry, but due to my current workload, I don't have the capacity to handle the PR at the moment. However, if the code review is completed in full, I can address all the corrections at once. Thank you.

would you mind maintainers send commits to your branch？

I don't mind, feel free to send commits to my branch. Editing is enabled. Thank you!

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2025
@github-actions github-actions bot removed modifies/translation modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/templates This PR modifies the template files modifies/docs modifies/migrations modifies/internal modifies/dependencies modifies/frontend docs-update-needed The document needs to be updated synchronously labels Feb 4, 2025
@lunny
Copy link
Member

lunny commented Feb 4, 2025

Integration test is still necessary.

lunny
lunny reviewed Feb 4, 2025
View reviewed changes
modules/structs/repo_actions.go
// ActionWorkflow represents a ActionWorkflow
type ActionWorkflow struct {
ID string `json:"id"`
NodeID string `json:"node_id"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems NodeID has never been used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny left review comments

@appleboy appleboy appleboy left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bencurio @KodingDev @lunny @appleboy @GiteaBot