Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the dashboard #32990

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Dec 26, 2024

before:
image

after:
image

image

Optimize the dashboard by adding welcoming messages or quick action entry points (such as adding a new repository or organization) to ensure that new users are not greeted by a blank page upon logging in.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 26, 2024
@kerwin612 kerwin612 requested a review from lunny December 26, 2024 07:47
Comment on lines 30 to 31
guide.welcome = Welcome to the Gitea.
guide.welcome_desc = Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to merge APP_NAME here, for giving user more freedom of changing the word Gitea here and the description.
We have APP_NAME in app.ini, but it seems that it is too long in here.
Maybe we can add APP_DESCRIPTION or something else.
You can also find the default value of startpage.app_desc is a part of guide.welcome_desc


.dashboard #dashboard-repo-list.is-loading {
aspect-ratio: 5.415; /* the size is about 790 x 145 */
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such trick can't be right

@kerwin612
Copy link
Member Author

image

@lunny
Copy link
Member

lunny commented Jan 2, 2025

image

Maybe remove the border of the left and put some text rather than Gitea logo

@kerwin612
Copy link
Member Author

image
Is this ok?

@kerwin612
Copy link
Member Author

image
latest screenshots

@lunny lunny added this to the 1.24.0 milestone Jan 2, 2025
@silverwind
Copy link
Member

silverwind commented Jan 13, 2025

I'd:

  • Downsize icon and title slightly
  • Make the text and icon slightly faded
  • Add a short "title" on left side too like "No Activity" and make the paragraph below with the text maybe 16px size.
  • Remove new repo/new migration buttons, they are duplicate with the + icon above.

@wxiaoguang
Copy link
Contributor

And one more thing, the "stop" icon is not suitable for this case (the users will have the question: why the icon tells me to stop here?), it needs a proper icon (if there must be an icon)

@silverwind
Copy link
Member

silverwind commented Jan 15, 2025

And one more thing, the "stop" icon is not suitable for this case (the users will have the question: why the icon tells me to stop here?), it needs a proper icon (if there must be an icon)

I agree, this icon is too close to a street sign. Kind of hard to find a suitable icon. Maybe an empty window will do:

https://www.svgrepo.com/svg/478290/empty-window

@kerwin612
Copy link
Member Author

image
latest screenshots

@kerwin612
Copy link
Member Author

Regarding the selection of appropriate icons, i can make the changes after team discussed and confirmed the options. Is that okay?

@lunny
Copy link
Member

lunny commented Jan 16, 2025

I think the right icon should also be changed.

@kerwin612
Copy link
Member Author

image

image

latest screenshots

@techknowlogick
Copy link
Member

I haven't looked at the code, but the latest screenshots look good to me

@yp05327
Copy link
Contributor

yp05327 commented Jan 17, 2025

Following an organization will also get some activities or not?

@silverwind
Copy link
Member

silverwind commented Jan 23, 2025

I agree, screenshot looks good. The code needs more cleanup before I can approve, especially #32990 (comment). Also please rebase.

@silverwind
Copy link
Member

silverwind commented Jan 23, 2025

Oh one more minor thing:

image

Can you make the vertical padding before the icon and after the text equal? Add a bit more on top.

@kerwin612
Copy link
Member Author

I agree, screenshot looks good. The code needs more cleanup before I can approve, especially #32990 (comment). Also please rebase.

I've replied to this comment. As I said in my reply, actually I didn't understand what it meant. Could you explain it to me again? Thank you!

@kerwin612
Copy link
Member Author

Can you make the vertical padding before the icon and after the text equal? Add a bit more on top.

Sure, I'll update it later!

@kerwin612
Copy link
Member Author

image
image
Actually, they are already equal, both being 1em. However, due to factors such as text size and font, there might be a slight visual difference.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/frontend modifies/templates This PR modifies the template files modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants