Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject star-related requests if stars are disabled #33208

Merged
merged 13 commits into from
Feb 4, 2025
Merged

Reject star-related requests if stars are disabled #33208

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c49823c
api: respect DISABLE_STARS config option
HeCorr Jan 10, 2025
7527a40
Merge branch 'main' into actually_disable_stars
techknowlogick Jan 22, 2025
2c5d553
api: remove disabled stars check from models
HeCorr Jan 23, 2025
39a1b4c
Merge remote-tracking branch 'origin/actually_disable_stars' into act…
HeCorr Jan 23, 2025
10d9507
api: remove APIGone and regen swagger template
HeCorr Jan 23, 2025
7bd7761
Merge remote-tracking branch 'origin/main' into actually_disable_stars
HeCorr Feb 2, 2025
1b9d569
Check for DisableStars inside middlewares
HeCorr Feb 3, 2025
999e43d
Middlewares go before handlers in m.Get()
HeCorr Feb 3, 2025
df4f803
Write APIStarDisabled tests
HeCorr Feb 3, 2025
59b9147
Use middleware for DisableStars check on actions too
HeCorr Feb 3, 2025
eb07bec
Deduplicate stars middlewares
HeCorr Feb 3, 2025
2458ac0
Update routers/web/repo/repo.go
wxiaoguang Feb 4, 2025
f630746
Merge branch 'main' into actually_disable_stars
GiteaBot Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions routers/api/v1/repo/star.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"net/http"

repo_model "code.gitea.io/gitea/models/repo"
"code.gitea.io/gitea/modules/setting"
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/routers/api/v1/utils"
"code.gitea.io/gitea/services/context"
Expand Down Expand Up @@ -44,6 +45,13 @@ func ListStargazers(ctx *context.APIContext) {
// "$ref": "#/responses/UserList"
// "404":
// "$ref": "#/responses/notFound"
// "403":
// "$ref": "#/responses/forbidden"

if setting.Repository.DisableStars {
HeCorr marked this conversation as resolved.
Show resolved Hide resolved
ctx.Error(http.StatusForbidden, "StarsDisabled", "Stars are disabled.")
return
}

stargazers, err := repo_model.GetStargazers(ctx, ctx.Repo.Repository, utils.GetListOptions(ctx))
if err != nil {
Expand Down
34 changes: 34 additions & 0 deletions routers/api/v1/user/star.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
access_model "code.gitea.io/gitea/models/perm/access"
repo_model "code.gitea.io/gitea/models/repo"
user_model "code.gitea.io/gitea/models/user"
"code.gitea.io/gitea/modules/setting"
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/routers/api/v1/utils"
"code.gitea.io/gitea/services/context"
Expand Down Expand Up @@ -66,6 +67,13 @@ func GetStarredRepos(ctx *context.APIContext) {
// "$ref": "#/responses/RepositoryList"
// "404":
// "$ref": "#/responses/notFound"
// "403":
// "$ref": "#/responses/forbidden"

if setting.Repository.DisableStars {
HeCorr marked this conversation as resolved.
Show resolved Hide resolved
ctx.Error(http.StatusForbidden, "StarsDisabled", "Stars are disabled.")
return
}

private := ctx.ContextUser.ID == ctx.Doer.ID
repos, err := getStarredRepos(ctx, ctx.ContextUser, private)
Expand Down Expand Up @@ -97,6 +105,13 @@ func GetMyStarredRepos(ctx *context.APIContext) {
// responses:
// "200":
// "$ref": "#/responses/RepositoryList"
// "403":
// "$ref": "#/responses/forbidden"

if setting.Repository.DisableStars {
ctx.Error(http.StatusForbidden, "StarsDisabled", "Stars are disabled.")
return
}

repos, err := getStarredRepos(ctx, ctx.Doer, true)
if err != nil {
Expand Down Expand Up @@ -128,6 +143,13 @@ func IsStarring(ctx *context.APIContext) {
// "$ref": "#/responses/empty"
// "404":
// "$ref": "#/responses/notFound"
// "403":
// "$ref": "#/responses/forbidden"

if setting.Repository.DisableStars {
ctx.Error(http.StatusForbidden, "StarsDisabled", "Stars are disabled.")
return
}

if repo_model.IsStaring(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID) {
ctx.Status(http.StatusNoContent)
Expand Down Expand Up @@ -160,6 +182,11 @@ func Star(ctx *context.APIContext) {
// "404":
// "$ref": "#/responses/notFound"

if setting.Repository.DisableStars {
ctx.Error(http.StatusForbidden, "StarsDisabled", "Stars are disabled.")
return
}

err := repo_model.StarRepo(ctx, ctx.Doer, ctx.Repo.Repository, true)
if err != nil {
if errors.Is(err, user_model.ErrBlockedUser) {
Expand Down Expand Up @@ -193,6 +220,13 @@ func Unstar(ctx *context.APIContext) {
// "$ref": "#/responses/empty"
// "404":
// "$ref": "#/responses/notFound"
// "403":
// "$ref": "#/responses/forbidden"

if setting.Repository.DisableStars {
ctx.Error(http.StatusForbidden, "StarsDisabled", "Stars are disabled.")
return
}

err := repo_model.StarRepo(ctx, ctx.Doer, ctx.Repo.Repository, false)
if err != nil {
Expand Down
17 changes: 12 additions & 5 deletions routers/web/repo/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,13 @@ func Action(ctx *context.Context) {
err = repo_model.WatchRepo(ctx, ctx.Doer, ctx.Repo.Repository, true)
case "unwatch":
err = repo_model.WatchRepo(ctx, ctx.Doer, ctx.Repo.Repository, false)
case "star":
err = repo_model.StarRepo(ctx, ctx.Doer, ctx.Repo.Repository, true)
case "unstar":
err = repo_model.StarRepo(ctx, ctx.Doer, ctx.Repo.Repository, false)
case "star", "unstar":
if setting.Repository.DisableStars {
err = errors.New("stars are disabled")
} else {
err = repo_model.StarRepo(ctx, ctx.Doer,
ctx.Repo.Repository, ctx.PathParam("action") == "star")
}
case "accept_transfer":
acceptTransfer(ctx)
return
Expand All @@ -377,7 +380,11 @@ func Action(ctx *context.Context) {
case "watch", "unwatch":
ctx.Data["IsWatchingRepo"] = repo_model.IsWatching(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID)
case "star", "unstar":
ctx.Data["IsStaringRepo"] = repo_model.IsStaring(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID)
if setting.Repository.DisableStars {
ctx.Data["IsStaringRepo"] = false
} else {
ctx.Data["IsStaringRepo"] = repo_model.IsStaring(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID)
}
}

// see the `hx-trigger="refreshUserCards ..."` comments in tmpl
Expand Down
4 changes: 4 additions & 0 deletions routers/web/repo/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,10 @@ func Watchers(ctx *context.Context) {

// Stars render repository's starred users
func Stars(ctx *context.Context) {
if setting.Repository.DisableStars {
HeCorr marked this conversation as resolved.
Show resolved Hide resolved
ctx.NotFound("Stars disabled", nil)
return
}
ctx.Data["Title"] = ctx.Tr("repo.stargazers")
ctx.Data["CardsTitle"] = ctx.Tr("repo.stargazers")
RenderUserCards(ctx, ctx.Repo.Repository.NumStars, func(opts db.ListOptions) ([]*user_model.User, error) {
Expand Down
15 changes: 15 additions & 0 deletions templates/swagger/v1_json.tmpl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.