Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize makefile help information generation #33390

Merged
merged 9 commits into from
Jan 27, 2025
Merged

Conversation

hiifong
Copy link
Member

@hiifong hiifong commented Jan 25, 2025

Get help information from the target's comments.

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 25, 2025
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 25, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2025
@silverwind
Copy link
Member

silverwind commented Jan 25, 2025

Maybe we can put the # title on its own line, before the target name/phony? It seems a bit suboptimal placement when there is a long dependency list.

@silverwind
Copy link
Member

Maybe we can put the # title on its own line, before the target name/phony? It seems a bit suboptimal placement when there is a long dependency list.

Thought that would make placing any non-public comments like this # workaround step a bit odd, so idk, maybe current way is fine.

@hiifong
Copy link
Member Author

hiifong commented Jan 26, 2025

Maybe we can put the # title on its own line, before the target name/phony? It seems a bit suboptimal placement when there is a long dependency list.

If the dependency list is too long, I think we can replace it with a variable.

@hiifong
Copy link
Member Author

hiifong commented Jan 26, 2025

Maybe we can put the # title on its own line, before the target name/phony? It seems a bit suboptimal placement when there is a long dependency list.

Thought that would make placing any non-public comments like this # workaround step a bit odd, so idk, maybe current way is fine.

Yes, the use of ## is to distinguish it from regular comments

@silverwind
Copy link
Member

Maybe we can put the # title on its own line, before the target name/phony? It seems a bit suboptimal placement when there is a long dependency list.

Thought that would make placing any non-public comments like this # workaround step a bit odd, so idk, maybe current way is fine.

Yes, the use of ## is to distinguish it from regular comments

Hmm no, I think that'd be worse 😆

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 26, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 27, 2025
@lunny lunny enabled auto-merge (squash) January 27, 2025 01:14
@go-gitea go-gitea deleted a comment from GiteaBot Jan 27, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 27, 2025
@lunny lunny merged commit 26b51aa into go-gitea:main Jan 27, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 27, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants