Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions FetchTask concurrently picked jobs is an error for the runner #33497

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Actions FetchTask concurrently picked jobs is an error for the runner #33497

wants to merge 1 commit into from

Conversation

ChristopherHX
Copy link
Contributor

  • Before this Gitea claimed no job is available to be picked in this case
  • The runner had to wait for an external taskversion increment
  • Now act_runner is notified about an error and retries the request later without updating its taskversion

Closes #33492

@ChristopherHX
Actions FetchTask concurrently picked jobs is an error for the runner
0395d5c 
* Before this Gitea claimed no job is available to be picked in this case
* The runner had to wait for an external taskversion increment
* Now act_runner is notified about an error and retries the request later without updating its taskversion
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 4, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 4, 2025
@ChristopherHX
Copy link
Contributor Author

This has been tested against my defect gitea docker image on a raspberry pi 4 arm64 by replacing the gitea binary with an custom backport to the 1.23.x release branch.
I didn't want to upgrade my database to the main branch and couldn't reproduce this on my stronger hardware

I wonder what are/were the reasons to not return an error in this situation?
The taskversion might has been an addition at a much later point of time conflicting with the original reason.

Bad aspects are, this logs unknown internal errors now while it appears to work all jobs get picked up now.

This is a draft PR, not 100% sure at this point if this patch should be merged like it is currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitea Actions FetchTask not reliable assigning queued jobs to idle runners as long no new jobs are queued
2 participants
@ChristopherHX @GiteaBot