-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: template: add configuration validation step #12535
base: main
Are you sure you want to change the base?
website/integrations: template: add configuration validation step #12535
Conversation
Adds configuration validation section of the template for tana to validate before adding everywhere. Draft 1 Signed-off-by: 4d62 <[email protected]>
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
## Configuration verification | ||
|
||
To confirm that authentik is properly configured with Service Name, log out and log back in via authentik. Specify the validation method (e.g., clicking a button), including its location and label for clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Draft 1 of what we discussed. For the second sentence, will probably need to make it stand out a bit. Once this step is validated, I'll update the integration documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @tanberry
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12535 +/- ##
==========================================
+ Coverage 92.75% 92.76% +0.01%
==========================================
Files 769 769
Lines 38840 38840
==========================================
+ Hits 36026 36031 +5
+ Misses 2814 2809 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding this, a few tweaks please,
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Ill have to update your suggestion as it breaks the build: |
Signed-off-by: 4d62 <[email protected]>
LMK io this is OK with you. Otherwise, we could find another placeholder identifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @4d62 !
Marked as ready for review to allow merge |
sdko/feat/integration-template/verification-step
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)