website/integrations: owncloud: document #12540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply changes from old MR
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Some easy fixes to match template
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12540 +/- ##
==========================================
- Coverage 92.75% 92.69% -0.06%
==========================================
Files 769 769
Lines 38840 38840
==========================================
- Hits 36026 36004 -22
- Misses 2814 2836 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tanberry
reviewed
Jan 3, 2025
tanberry
reviewed
Jan 3, 2025
tanberry
reviewed
Jan 3, 2025
tanberry
reviewed
Jan 3, 2025
tanberry
reviewed
Jan 3, 2025
tanberry
reviewed
Jan 3, 2025
tanberry
reviewed
Jan 3, 2025
|
Thanks for this review Tana. Didn't have a chance to finish cleaning the PR up after merging the old changes |
4d62
commented
Jan 3, 2025
Cleans up the authentik configuration section of this documentation and removes unneeded bits
Add `### Configuration` header and switch General Settings, Protocl Settings, and Advanced Protocol Settings to H4
…move unneeded block Updates the service discovery block to be more in-line with documentation, renames "Apache" to "Apache HTTPD" (correct name), removes provider specific documentation for traefik and instead tells users to view provider-specific docs. Also removes section kept last commit
…ion" section Starts cleaning up the steps, adds warning for sub and the other one, grammar, styling and bla bla bla
Adds single quotes for client-id and client-secret lines. Should be fine I think. Logic says quotes but old docs had none
Cleanup and restructure the section
Cleanup the rest of the ownCloud section and update the loginButtonName variable
Lints the code with Prettier
again (?)
tanberry
reviewed
Jan 7, 2025
Applies Tana's suggested format/layout with my suggested modifications. Lint will probably fail so enjoy this nice red cross on the right of this commit :) Signed-off-by: 4d62 <[email protected]>
Yea... That's about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdko/feat/integration/pickup-10943-owncloud
Closes #10943
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)