Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/authenticator: add user field to devices #12636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 10, 2025

Details

Fix missing user fields. This was somehow missed in the API as we never displayed data like that or queried it ourselves like that.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners January 10, 2025 16:39
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 52956c7
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6781c98a9227bb00077c032c

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 52956c7
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6781c98a8b7bdd0008479ae1
😎 Deploy Preview https://deploy-preview-12636--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (29f8a82) to head (52956c7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12636      +/-   ##
==========================================
+ Coverage   92.75%   92.76%   +0.01%     
==========================================
  Files         769      769              
  Lines       38840    38850      +10     
==========================================
+ Hits        36025    36040      +15     
+ Misses       2815     2810       -5     
Flag Coverage Δ
e2e 48.64% <100.00%> (+0.03%) ⬆️
integration 24.63% <0.00%> (-0.01%) ⬇️
unit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-52956c70b39302b12f12a559d214fa8b4cebf19f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-52956c70b39302b12f12a559d214fa8b4cebf19f-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-52956c70b39302b12f12a559d214fa8b4cebf19f

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-52956c70b39302b12f12a559d214fa8b4cebf19f-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the stages/authenticator/include-user branch from 58e910c to 52956c7 Compare January 11, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant