-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: Add documentation for Drupal #12925
website/integrations: Add documentation for Drupal #12925
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution. Before reviewing this PR, would it be possible to make sure your contribution follows the template outlined in the documentation? Thanks.
@dominic-r I've made this change (however the authentik configuration needs to happen before the Drupal configuration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @justafish . Thanks for your contribution. Here are a few comments. Please do let me know if you have any questions.
::: | ||
|
||
|
||
## authentik configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to tana: reminder: will update format in a later PR
Hi @justafish. Just checking in to see if there are any developments related to this PR. thanks |
@dominic-r I've addressed your feedback 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @justafish for this contribution. I was shocked that we didn't already have an integration guide for Drupal; now we do, thanks to you!
I made a few more minor edits, once those are in let's get this merged!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12925 +/- ##
==========================================
- Coverage 92.75% 92.66% -0.10%
==========================================
Files 769 793 +24
Lines 38929 40268 +1339
==========================================
+ Hits 36109 37314 +1205
- Misses 2820 2954 +134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Sally Young <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Sally Young <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Sally Young <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Sally Young <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Sally Young <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Sally Young <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Sally Young <[email protected]>
Hi @justafish thanks for the updates! Looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the above ^^ is addressed, LGTM.
There is one thing, but it is more of a preference/opinion: If the indications on how to reach a specific page are clear enough, you don't need to include the link, especially since it uses a placeholder which will need to get replaced and updating the url will take more time than actually following the instructions.
@@ -0,0 +1,82 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the image since it's no longer used? (drupal_2fa.png)
@tanberry I've run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @justafish for adding Drupal docs!! Very nice to have.
Details
Adds documentation for authentication with Drupal
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)