Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup for cve-bench #20

Merged
merged 8 commits into from
Mar 30, 2022
Merged

Initial setup for cve-bench #20

merged 8 commits into from
Mar 30, 2022

Conversation

vesalvojdani
Copy link
Member

@vesalvojdani vesalvojdani commented Mar 1, 2022

I'm creating this pull request to get some input on how we should set up these GobPie demonstrators (#22).

  1. How to set up the harnessing. I was thinking that maybe we should go the ldv approach, but that's a fairly ugly demo to open the preprocessed file in the GUI. The alternative is to rely on Goblint's own amazingly sound auto-harness features (i.e., beauties like otherfuns), which we might survive for now...
  2. The problem if we do not merge the files is that we need different versions of include files. I guess one could have the needed include files for each project here and set the kernel directory flag.

The current CVE included here should work with our current include files. My question is what we should do to make these work more-or-less out of the box with GobPie.

@vesalvojdani
Copy link
Member Author

Also, narrowing these down to CVE may be a bad idea. If there is a good example from ldv-commit-races, we could use that here too, but I don't think we want them preprocessed for a demonstrator.

@sim642
Copy link
Member

sim642 commented Mar 1, 2022

Already preprocessed files with all the #line macros won't work with GobPie anyway, because through CIL our locations for warnings will refer to those (absolute) pre-merging paths. But because they don't exist, the warnings don't show up anywhere.
So we'd have to strip the #lines anyway.

@sim642 sim642 added the new benchmark New benchmark to analyze label Mar 2, 2022
@vesalvojdani vesalvojdani merged commit 031efb0 into master Mar 30, 2022
@vesalvojdani vesalvojdani deleted the cve-bench branch March 30, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new benchmark New benchmark to analyze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants