Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instancing.zip for Godot 4 #6187

Closed
wants to merge 1 commit into from
Closed

Update instancing.zip for Godot 4 #6187

wants to merge 1 commit into from

Conversation

strawberrybeach
Copy link

@strawberrybeach strawberrybeach commented Sep 16, 2022

This commit slightly changes Main.gd in the instancing sample, so it works with 4.0.

Used the migrate project thing, only had to change 1 thing manually:
export (PackedScene) var Ball changed to var Ball = load("res://Ball.tscn")

Closes #6564.

@Calinou
Copy link
Member

Calinou commented Sep 16, 2022

We should really move this demo to the godot-demo-projects repository instead of updating a ZIP file. Otherwise, we'll keep bloating the Git history with a binary file every time the demo has to be updated for any reason.

@Calinou Calinou added the bug label Sep 16, 2022
@skyace65 skyace65 added the area:getting started Issues and PRs related to the Getting Started section of the documentation label Jan 13, 2023
@andreymal
Copy link

Both old and new instancing.zip have smaller collision shapes when importing to Godot 4. Is it some migration bug?

godot-collisions

rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:

https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:

https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:

https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:

https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:

https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:
https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Added a small section about instancing via code.

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 4, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:
https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Added a small section about instancing via code.

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 4, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:
https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Added a small section about instancing via code.

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
rm-code added a commit to rm-code/godot-docs that referenced this pull request Mar 6, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:
https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Added a small section about instancing via code.

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
@skyace65
Copy link
Contributor

Superseded by #7222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived area:getting started Issues and PRs related to the Getting Started section of the documentation bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated example project
4 participants