-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace setting by reference with ties #100445
Conversation
41bd7ea
to
711da70
Compare
711da70
to
bddbf5e
Compare
@arkology You probably wanted to refer to the "Standard Template Library" headline, not the one regarding the "auto" keyword? ^^ But yeah, Godot codebase does not accept |
@RedMser previous the author also used |
I don't see any mentions of tuples in the rules. I can update the docs to include an explanation of why they aren't allowed if you explain the reason to me. |
I'm really sorry if it sounds offensive. You are right, the docs don't mention it directly. Feel free to open an issue on the Godot Docs repo. |
No offense taken. You were explaining the spirit of the rules and it simply didn't match the letter of the rules. Easy fix! |
I've made an issue mentioning this. Since this change isn't allowed I'll close this PR. |
Shortens the method signature and make the code smaller. Pure positives!