Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock caused by nested thread groups in RaycastOcclusionCull #102018

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jadeharley2
Copy link
Contributor

Should fix deadlock which is described in 86306#issuecomment-2604466301

// Lots of instances, use per-instance threading
and
// Few instances, use threading on the vertex transforms
state that there is should be only one threaded group call in both branches, possibly to avoid deadlocks like described above. So the fix is to add a variable to check if we are already in a threaded call.

@jadeharley2 jadeharley2 requested a review from a team as a code owner January 25, 2025 12:53
@jadeharley2
Copy link
Contributor Author

I've messed up with git again, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants