Skip Object::to_string when Jolt Physics is on separate thread
#102726
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2025
akien-mga
reviewed
Feb 11, 2025
mihe
force-pushed
the
jolt/thread-safe-errors
branch
from
f42cc4a to
efaee41
Compare
mihe
force-pushed
the
jolt/thread-safe-errors
branch
from
efaee41 to
1006fa9
Compare
akien-mga
approved these changes
Feb 11, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102638.
Supersedes #102717.
This PR changes the error reporting happening in
modules/jolt_physicsso as to not fetch the actual object/node name when usingphysics/3d/run_on_separate_thread, but instead just fall back to using<unknown>as the name, asObject::to_stringis not thread-safe.(I also removed
JoltSoftBody3D::to_string, which seemed to be entirely redundant.)