Fix wrong viewport scaling at intermediate resolutions #102741
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes viewport scale being wrong at resolutions that are not integer multiples of content_scale_factor. This is done by allowing size_2d_override to be Size2 instead of Size2i. This change is propagated to keep the exposed SubViewport consistent with the underlying implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102656: viewport scale is wrong at resolutions that are not integer multiples of content_scale_factor.
This is done by allowing size_2d_override to be Size2 instead of Size2i. This change is propagated to keep the exposed SubViewport consistent with the underlying implementation. Looking for feedback on whether exposing this in a fix is preferred or not.
Note:
I see the output of
Viewport::get_visible_rect()get treated as a Rect2i in some places, even though it returns a Rect2. Before this change, this might have been accidentally correct, since it was generated from eithersizeorsize_2d_override, which were both Size2i. It might need a second look to make sure it still works correctly, because I'm not exactly sure what all these code fragments do.