JavaClassWrapper: Improve handling of typed array arguments #102817
+264
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102712
There are 3 issues that come from that:
Packed*Array
types) into account when selected an overloaded method[x] vararg methods aren't supportedJavaObject
s aren't supported (this one I noticed while working on this)So far, this PR only fixes the first one, which is why this is currently marked as DRAFT.UPDATE: All the issues are fixed now in my testing!
UPDATE 2: I ended up deciding to remove the explicit support for varargs - see this comment.