[ENet] Explicitely destroy hosts on close #102861
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure we free up the UDP port even if a script is holding a reference to the underlying host, we need to explicitly destroy it on close.
akien-mga
approved these changes
Feb 14, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we free up the UDP port even if a script is holding a reference to the underlying host, we need to explicitly destroy it on close.
This is a partial fix to #102822 .
We can't really properly fix it if C# keeps references to RefCounted objects longer than their lifetime, but we can at least make sure that if you hold a reference to the underlying host, and you explicitly call ENetMultiplayerPeer::close, the underlying socket gets properly closed.