Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Leap Hand Models #124

Merged
merged 6 commits into from
Dec 6, 2024
Merged

New Leap Hand Models #124

merged 6 commits into from
Dec 6, 2024

Conversation

alberthli
Copy link
Contributor

@alberthli alberthli commented Dec 5, 2024 •
edited
Loading

As per conversation, this PR updates the Leap hand XMLs with a different version modified from the dexsuite URDF.

Completed:

  • Left and right hands completed
  • Updated README to reflect the new URDF -> MJCF creation process + differences between left and right
  • New screenshots of the hand models

@alberthli alberthli marked this pull request as ready for review December 5, 2024 08:26
@kevinzakka kevinzakka self-requested a review December 5, 2024 19:18
kevinzakka
kevinzakka approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@kevinzakka kevinzakka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I've emailed Yuzhe to see if we can keep the changes under MIT

@kevinzakka
Copy link
Collaborator

OK, confirmed via Yuzhe that this is MIT and will remain MIT. All done then, thanks Albert!

@copybara-service copybara-service bot merged commit 286cfe3 into google-deepmind:main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzakka kevinzakka kevinzakka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alberthli @kevinzakka