-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Expectile Regression Naive implementation #10
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I think I should probably add a test case for expectile regression-naive, maybe a modified version of |
@googlebot I signed it! |
Yes please |
@mtthss , just to update you, I'm hoping to finish this next week. I'm slammed with psets and then the NeurIPS poster deadline, but I'm optimistic I'll have time over the weekend or next week. |
Perfect, thx for the update! |
Hello @RylanSchaeffer any chance we could finalize this? |
Continuing from #9, I made the minor changes Mark and Will recommended, but did not pursue writing
expectile_naive_regression_loss()
to work with expectile regression since properly implemented expectile regression is more complicated (and I think will require its own PR).