New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dqn example #121

Open

KaleabTessera wants to merge 2 commits into google-deepmind:master from KaleabTessera:fix/dqn-example

KaleabTessera commented Mar 14, 2023

This PR includes two fixes for the dqn example:

Fix import error:

Traceback (most recent call last):
  File "examples/simple_dqn.py", line 28, in <module>
    from rlax.examples import experiment
ModuleNotFoundError: No module named 'rlax.examples'

There is already a PR for this, but this fixes the whole dqn example.

Fix epsilon scheduling (Epsilon keeps getting reintialized in the example script #102).

These lines (1 , 2) reset the actor steps, which results in the wrong counts being passed to the eps scheduling function here. This outcome of this is a cyclic eps schedule which is not intended.

KaleabTessera added 2 commits

March 14, 2023 13:46


          fix: Fixed experiment import.

157a52c


          fix: Fixed epsilon scheduling due to actor count getting reset every …

2ffc089

…time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet