This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
Only listen for HTTP challenge when needed. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I'm right now only using manual challenges, I was surprised that the code nevertheless listened on 127.0.0.1:8080 during "acme cert". This change moves the listening setup inside the appropriate case. UNTESTED, but it looks trivial ;-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm right now only using manual challenges, I was surprised that the
code nevertheless listened on 127.0.0.1:8080 during "acme cert".
This change moves the listening setup inside the appropriate case.
UNTESTED, but it looks trivial ;-)