-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ru: translate days 1-2 section titles #1973
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add translations for new extracted messages related to Day 1 chapter; * Fix numbering of Day 4 titles; * Heavily use PO file translator comments for notes and reasons why one or another choice was made, mention alternatives; * Rename: Поток управления -> Управляющие конструкции; * Rename: Перечисления и сопоставление с образцом. -> Деструктуризация; * Rename: Ссылки -> Заимствование; * Rename: Висячие ссылки -> Изменяемые ссылки; * Rename: Вторая половина дня -> После обеда; * Cannot translate `Slices: &[T]`: there must be a bug with no message id for the nav item (TODO: reproduce & localize);
* Add translations for new extracted messages related to Day 2 morning chapter; * Rename: Поток управления -> `Let` в потоке управления (Let Control Flow); * Rename: Функции -> Обобщённые функции (Generic Functions); * Rename: Обобщения (generics). -> Обобщённые типажи (Generic Traits);
* Add translations for the new extracted messages related to Day 2 Afternoon; * Do not translate type and trait names;
1dimir
requested review from
istolga,
baltuky,
zvonden and
dyeroshenko
as code owners
April 11, 2024 08:06
I'm looking into failed |
* Ensure translator comments come before references
Resolved |
mgeisler
reviewed
Apr 12, 2024
Makarevich
reviewed
Apr 16, 2024
dyeroshenko
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: For future PRs, can we try to have 1-2 commits per PR? It's just more convenient to review smaller changes.
Other than that, LGTM and huge thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let
в потоке управления (src: Let Control Flow);Slices: &[T]
- possible bug#326