Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing query params to AlertListOptions #3477

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

maaarcelino
Copy link
Contributor

As per the official documentation the endpoints to list alerts for both an organization and a repository accept three additional params which are not included in this SDK. Those are: tool_guid, direction and sort.

See:

This PR adds those fields and extends the tests to cover them as well.

@maaarcelino
Copy link
Contributor Author

I ran the linting, testing and generation scripts. @gmlewis can you please take a look? 🙏

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (77684a4) to head (022dd98).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3477   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files         179      179           
  Lines       15551    15551           
=======================================
  Hits        14158    14158           
  Misses       1221     1221           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maaarcelino!
LGTM.
Merging.

@gmlewis gmlewis merged commit c4b2cb9 into google:master Feb 12, 2025
7 checks passed
@maaarcelino maaarcelino deleted the fix/list-alerts-options branch February 13, 2025 10:17
@maaarcelino
Copy link
Contributor Author

@gmlewis Thanks! Any word on when I can expect a new release? Is there any chance you could do a minor release sooner than later?

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 13, 2025

Usually we cut a release monthly, but we've also tried to be accommodating to requests, so I can work on a minor release.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 13, 2025

@gmlewis Thanks! Any word on when I can expect a new release? Is there any chance you could do a minor release sooner than later?

Done: https://github.com/google/go-github/releases/tag/v69.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants