Add payload inspection to htool/libhoth #85
Conversation
stevenportley
requested review from
rkr35,
daimeng-wang,
cjevans-google,
aranikam and
xorptr
stevenportley
force-pushed
the
payload_info
branch
2 times, most recently
from
03697a1 to
40f8be3
Compare
stevenportley
force-pushed
the
payload_info
branch
2 times, most recently
from
ecef652 to
7414a87
Compare
| printf(" type: %u\n", info.image_type); | ||
| printf(" hash: "); | ||
| for (int i = 0; i < sizeof(info.image_hash); i++) { | ||
| printf("%x", info.image_hash[i]); |
There was a problem hiding this comment.
Would it be a good idea to add zeros on the left to pad to 2 characters?
There was a problem hiding this comment.
I'm not sure what you mean by this? This output is as follows, which I think is reasonable:
Payload Info:
name: test layout
family: 2
version: 1.0.0.0
type: 0
hash: 50316da1d3b06ff87989aa8bcd48a33ecc4bfe2114ded138ee594f697d58b3
There was a problem hiding this comment.
len("50316da1d3b06ff87989aa8bcd48a33ecc4bfe2114ded138ee594f697d58b3") = 62, but there should be 64 characters in the output (2 characters per byte for 32 bytes)
stevenportley
force-pushed
the
payload_info
branch
7 times, most recently
from
ae9d2b8 to
e36b203
Compare
stevenportley
force-pushed
the
payload_info
branch
from
e36b203 to
af3133b
Compare
|
|
||
| int ret = munmap(image, statbuf.st_size); | ||
| if (ret != 0) { | ||
| fprintf(stderr, "munmap error: %d\n", ret); |
There was a problem hiding this comment.
Would it be a good idea to print strerror(errno) here as well (similar to what has been done for mmap?
| printf(" type: %u\n", info.image_type); | ||
| printf(" hash: "); | ||
| for (int i = 0; i < sizeof(info.image_hash); i++) { | ||
| printf("%x", info.image_hash[i]); |
There was a problem hiding this comment.
len("50316da1d3b06ff87989aa8bcd48a33ecc4bfe2114ded138ee594f697d58b3") = 62, but there should be 64 characters in the output (2 characters per byte for 32 bytes)
Add payload inspection to libHoth and an option to htool:
htool payload info protocol/test/test_payload.bin
Payload Info:
name: test layout
family: 2
version: 1.0.0.0
type: 0
hash: 50316da1d3b06ff87989aa8bcd48a33ecc4bfe2114ded138ee594f697d58b3