Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test extracting text from multiple books #115

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

mgeisler
Copy link
Collaborator

@mgeisler mgeisler commented Nov 8, 2023

This expands our testing to test extracting text from both the Rust Book and Comprehensive Rust. We only check the format of the generated POT file right now, but we might be able to expand this to other checks later.

This expands our testing to test extracting text from both the Rust
Book and Comprehensive Rust. We only check the format of the generated
POT file right now, but we might be able to expand this to other
checks later.
@mgeisler mgeisler force-pushed the test-with-comprehensive-rust branch from 3b01fd8 to bb1ccde Compare November 8, 2023 08:55
@mgeisler mgeisler requested a review from dyoo November 8, 2023 08:55
@mgeisler
Copy link
Collaborator Author

mgeisler commented Nov 8, 2023

Hi @dyoo, I could use a similar matrix technique to run the fuzz tests in parallel. That would halve the running time of that test.

Copy link
Collaborator

@dyoo dyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but to be honest, I'm not familiar with github workflows!

@mgeisler
Copy link
Collaborator Author

mgeisler commented Nov 9, 2023

Looks reasonable to me, but to be honest, I'm not familiar with github workflows!

Not many people are 😄 But you see the two jobs on the checks tab and so you can inspect that it works as intended.

@mgeisler mgeisler merged commit 5058b3a into main Nov 9, 2023
7 checks passed
@mgeisler mgeisler deleted the test-with-comprehensive-rust branch November 9, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants