Skip to content

Commit

Permalink
Use std::make_pair instead of std::make_tuple for returning a pair of…
Browse files Browse the repository at this point in the history
… values.

* Follow-up to cl/697947002

#codehealth

PiperOrigin-RevId: 698251007
  • Loading branch information
hiroyuki-komatsu committed Nov 20, 2024
1 parent 8560692 commit 4f5383a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/composer/composer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,8 @@ std::pair<std::string, absl::btree_set<std::string>> GetQueriesForPrediction(
switch (input_mode) {
case transliteration::HALF_ASCII:
case transliteration::FULL_ASCII: {
return std::make_tuple(GetQueryForPrediction(composition, input_mode),
absl::btree_set<std::string>());
return std::make_pair(GetQueryForPrediction(composition, input_mode),
absl::btree_set<std::string>());
}
default: {
}
Expand All @@ -393,7 +393,7 @@ std::pair<std::string, absl::btree_set<std::string>> GetQueriesForPrediction(
const std::string asis = composition.GetStringWithTrimMode(ASIS);
RemoveExpandedCharsForModifier(asis, base_query, &expanded);

return std::make_tuple(
return std::make_pair(
japanese_util::FullWidthAsciiToHalfWidthAscii(base_query), expanded);
}

Expand Down
4 changes: 2 additions & 2 deletions src/composer/internal/composition.cc
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ Composition::GetExpandedStrings() const {
Transliterators::Transliterator transliterator = Transliterators::LOCAL;
if (chunks_.empty()) {
MOZC_VLOG(1) << "The composition size is zero.";
return std::make_tuple(std::string(), absl::btree_set<std::string>());
return std::make_pair(std::string(), absl::btree_set<std::string>());
}

std::string base;
Expand All @@ -287,7 +287,7 @@ Composition::GetExpandedStrings() const {
// Get expanded from the last chunk
const absl::btree_set<std::string> expanded =
chunks_.back().GetExpandedResults();
return std::make_tuple(base, expanded);
return std::make_pair(base, expanded);
}

std::string Composition::GetString() const {
Expand Down

0 comments on commit 4f5383a

Please sign in to comment.