Remove platform macros from tip_text_service.cc
#1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the dependency on platform macros such as _M_X64 and _M_IX86 from tip_text_service.cc. There must be no change in the final artifacts. This is a preparation to build Mozc for ARM64 (google#1130).
yukawa
force-pushed
the
support_arm64_in_tip_text_service
branch
from
2dd8273 to
1d3bf9b
Compare
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the dependency on platform macros such as
_M_X64and_M_IX86fromtip_text_service.cc.There must be no change in the final artifacts.
This is a preparation to build Mozc for ARM64 (#1130).
Issue IDs
Steps to test new behaviors (if any)
Mozc64.msi