Update rules_android_ndk to 0.1.13
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up to my previous commit [1], which aimed to make 'rules_android_ndk' compatible with 'allow_empty_glob' (google#1150) with our own local patch. As rules_android_ndk 0.1.13 does include the fix [2], we no longer need to keep maintaining our local patch. [1]: 990c417 [2]: bazelbuild/rules_android_ndk#98
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows up to my previous commit (990c417), which aimed to make
rules_android_ndkcompatible withallow_empty_glob(#1150) with our own local patch.As
rules_android_ndk0.1.13 does include the fix (bazelbuild/rules_android_ndk#98), we no longer need to keep maintaining our local patch.Issue IDs
--incompatible_disallow_empty_glob#1150Steps to test new behaviors (if any)
bazelisk build package --config oss_android --config release_build