Skip to content

Commit

Permalink
[Sharing Analytics] Log event for bandwidth quality change.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 684246964
  • Loading branch information
hai007 authored and copybara-github committed Oct 10, 2024
1 parent 45e297c commit c17c9df
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
7 changes: 6 additions & 1 deletion proto/sharing_enums.proto
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ option objc_class_prefix = "GNSHP";
// in NearbyClearcutLogger (for android, or clearcut_event_logger as the
// equivalence for Windows) for all events (may exclude settings), and
// session_id for a pair of events (start and end of a session).
// Next id: 68
// Next id: 70
enum EventType {
UNKNOWN_EVENT_TYPE = 0;

Expand Down Expand Up @@ -297,6 +297,11 @@ enum EventType {
// Show accept button on Quick Share receive UI
WAITING_FOR_ACCEPT = 67;

// High quality event setup
HIGH_QUALITY_MEDIUM_SETUP = 68;

// Hight quality event setup timeout
HIGH_QUALITY_MEDIUM_TIMEOUT = 69;
// LINT.ThenChange(//depot/google3/location/nearby/proto/nearby_event_codes.proto:SharingEventCode)
}

Expand Down
10 changes: 9 additions & 1 deletion sharing/proto/analytics/nearby_sharing_log.proto
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ option objc_class_prefix = "GNCP";

// Top-level log proto for all NearbySharing logging.
// Each log contains a key (event_type), value (a verb-noun event) pair.
// Next Tag: 77
// Next Tag: 78
// LINT.IfChange
message SharingLog {
/* collection_basis = {
Expand Down Expand Up @@ -210,6 +210,8 @@ message SharingLog {

optional ShowWaitingForAccept show_waiting_for_accept = 76;

optional HighQualityMedium high_quality_medium = 77;

// Used only for Nearby Share Windows app now.
message AppInfo {
// e.g. "1.0.408"
Expand Down Expand Up @@ -895,5 +897,11 @@ message SharingLog {
message ShowWaitingForAccept {
optional location.nearby.proto.sharing.ButtonStatus button_status = 1;
}

message HighQualityMedium {
optional int64 session_id = 1 /* type = ST_SESSION_ID */;
optional location.nearby.proto.connections.Medium medium = 2;
optional int64 duration_millis = 3;
}
}
// LINT.ThenChange(//depot/google3/logs/proto/location/nearby/nearby_client_log.proto)

0 comments on commit c17c9df

Please sign in to comment.