-
Notifications
You must be signed in to change notification settings - Fork 89
Port Iron icons guide #155
base: master
Are you sure you want to change the base?
Conversation
…ection on 0.5 to 1.0 migration.
Bummer, I haven't hit this bug yet and just did a polycast on creating custom iconsets with iron-iconset-svg. Seems to work fine in the demo :\ |
cc @sjmiles who seems to be working on this a bit |
Did this PR fix the issue? PolymerElements/iron-iconset-svg#11 |
|
||
## Introduction | ||
|
||
In this guide we will teach you how to display icons and how to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General voice principal for pp.org: Use 2nd person present tense and try to avoid "we", unless you're providing a specific recommendation that comes from the Polymer team ("we recommend ...").
So I would usually write this as "This guide teaches you how to..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
So, I could be wrong but it looks like the bug regarding loading icon sets only applies when you dynamically load stuff, which I think is related to this issue: The demo for iron-iconset-svg seems to work on the catalog site: https://elements.polymer-project.org/elements/iron-iconset-svg?view=demo:demo/index.html It seems like we should probably document icon sets with this caveat. @cdata @sjmiles Can either of you comment on whether my interpretation is correct here? |
This seems to be true based on my experience, Arthur. However, Scott On Fri, Jul 31, 2015 at 2:33 PM Arthur Evans [email protected]
|
Ping @kaycebasques looks like we are out of the woods here! |
…ed class attribute because it doesn't appear necessary.
…lders. Refer to iron-icons as package. Fix usage of 2nd person.
hallo @arthurevans PTAL |
R (@tjsavage && (@ebidel || @robdodson))
social
,av
, etc. icon sets fromiron-icons
due to the same bug listed above.iron-icons
Polycast.