Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Port Iron icons guide #155

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Port Iron icons guide #155

wants to merge 20 commits into from

Conversation

kaycebasques
Copy link
Contributor

R (@tjsavage && (@ebidel || @robdodson))

  • Ported 0.5 guide to 1.0.
  • Removed sections on icon sets due to dependency loading bug. See Chrome Cannot Find Iconset PolymerElements/iron-icon#19.
  • Added section about needing to load dependencies in specific order when using the social, av, etc. icon sets from iron-icons due to the same bug listed above.
  • Added section on using mixins to style icons globally, in alignment with Rob's iron-icons Polycast.

@robdodson
Copy link

Bummer, I haven't hit this bug yet and just did a polycast on creating custom iconsets with iron-iconset-svg. Seems to work fine in the demo :\

@robdodson
Copy link

cc @sjmiles who seems to be working on this a bit

@robdodson
Copy link

Did this PR fix the issue? PolymerElements/iron-iconset-svg#11


## Introduction

In this guide we will teach you how to display icons and how to use the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General voice principal for pp.org: Use 2nd person present tense and try to avoid "we", unless you're providing a specific recommendation that comes from the Polymer team ("we recommend ...").

So I would usually write this as "This guide teaches you how to..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@arthurevans
Copy link
Contributor

So, I could be wrong but it looks like the bug regarding loading icon sets only applies when you dynamically load stuff, which I think is related to this issue:

PolymerElements/iron-icons#18

The demo for iron-iconset-svg seems to work on the catalog site:

https://elements.polymer-project.org/elements/iron-iconset-svg?view=demo:demo/index.html

It seems like we should probably document icon sets with this caveat.

@cdata @sjmiles Can either of you comment on whether my interpretation is correct here?

@cdata
Copy link

cdata commented Aug 6, 2015

This seems to be true based on my experience, Arthur. However, Scott
probably has a better insight into the full scope of caveats.

On Fri, Jul 31, 2015 at 2:33 PM Arthur Evans [email protected]
wrote:

So, I could be wrong but it looks like the bug regarding loading icon sets
only applies when you dynamically load stuff, which I think is related to
this issue:

PolymerElements/iron-icons#18
PolymerElements/iron-icons#18

The demo for iron-iconset-svg seems to work on the catalog site:

https://elements.polymer-project.org/elements/iron-iconset-svg?view=demo:demo/index.html

It seems like we should probably document icon sets with this caveat.

@cdata https://github.com/cdata @sjmiles https://github.com/sjmiles
Can either of you comment on whether my interpretation is correct here?


Reply to this email directly or view it on GitHub
#155 (comment)
.

@arthurevans
Copy link
Contributor

Ping @kaycebasques looks like we are out of the woods here!

@kaycebasques
Copy link
Contributor Author

hallo @arthurevans PTAL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants