Allow third party repository locations #177
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I signed it! |
|
CLAs look good, thanks! |
|
+1 |
|
heh, already sent in this pull request two months ago #156 |
|
+1 |
1 similar comment
|
+1 |
|
Pinging @frankiefu -- we have two PRs on this, can you PTAL? |
| @@ -47,6 +47,9 @@ | |||
| _element: Object, | |||
| iconsOnly: {type: Boolean, value: false, reflectToAttribute: true} | |||
| }, | |||
| repositoryLink: function(source) { | |||
| return (source.indexOf('http') >= 0) ? source : githubLink(source); | |||
There was a problem hiding this comment.
Hmm... How did that change ever work? There is no global githubLink. Should that be this._ githubLink instead?
There was a problem hiding this comment.
Oh I'm sorry, I've like 3 different versions of this project, and pushed the wrong one. Fixed
| @@ -47,7 +47,10 @@ | |||
| _element: Object, | |||
| iconsOnly: {type: Boolean, value: false, reflectToAttribute: true} | |||
| }, | |||
| githubLink: function(source) { | |||
| repositoryLink: function(source) { | |||
| return (source.indexOf('http') >= 0) ? source : this._githubLink(source); | |||
There was a problem hiding this comment.
Currently it will match if http is in any part of the source url. Can you change it to make sure it matches only if it starts with http?
There was a problem hiding this comment.
I'm sorry, I hope now it's fixed. Thanks frankiefu.
|
+1 |
Hi there,
I'm using polymer-element-catalog for generating our own project documentation, but there seems that source code's link always go to github, and we're using stash. I'd modified this file in order to allow full http links, instead of github relative repos.
I hope you like it, I think it'll help people like me to use their own repos.
Regards