-
Notifications
You must be signed in to change notification settings - Fork 89
replace backslashes to support windows filesystem #217
base: master
Are you sure you want to change the base?
Conversation
I think the solution here should be to split on |
we still have to replace the \ because we are replacing the base path with an empty string before splitting |
👍 It should use |
@@ -103,7 +103,7 @@ function getGuideName (filepath) { | |||
function formatParsedGuideFilepath (srcPath, destDir) { | |||
|
|||
var relativeSrcPath = srcPath | |||
.replace(process.cwd() + path.sep, '') | |||
.replace((process.cwd() + path.sep).replace(/\\/g, '/'), '') | |||
.split('/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split(path.sep)
Friendly ping @mcarey1590 on switching to |
the issue I see with switching to |
How about:
I think |
I tried Arthur's suggestion and window's path names were normalized correctly. This change has been added to pull request |
No description provided.